Voxel shadow fixes for interleaved buffers by MiiBond · Pull Request #17376 · BabylonJS/Babylon.js

MiiBond · 2025-10-31T18:27:49Z

This PR adds defines to assist with vertex pulling when the vertex buffers are interleaved.
I'm also including a fix by @Popov72 for IBL shadow voxelization when using bones.

bjsplat · 2025-10-31T18:29:23Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-10-31T18:30:48Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-10-31T18:45:21Z

Snapshot stored with reference name:
refs/pull/17376/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/17376/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17376/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17376/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17376/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17376/merge#BCU1XR#0

bjsplat · 2025-10-31T18:51:09Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-10-31T18:53:28Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-10-31T18:58:47Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-10-31T18:58:51Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/webgpuplaywright/index.html

packages/dev/core/src/ShadersWGSL/iblVoxelGrid.vertex.fx

bjsplat · 2025-10-31T22:08:52Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-10-31T22:10:52Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-10-31T22:11:23Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-10-31T22:11:30Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/devhostplaywright/index.html

MiiBond · 2025-11-07T19:33:00Z

@Popov72 I've included your fix and also made once that fixes the voxelization when calling it repeatedly.

This allows the voxelization to work with all the animated assets that I've tried.
Though, I suspect an animated asset that moves a lot will pass outside the bounds of the voxelization since the bounds update doesn't take skinning into account.

bjsplat · 2025-11-07T19:54:52Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-07T19:58:45Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-07T20:04:41Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-07T20:06:44Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/webgl2playwright/index.html

packages/dev/core/src/Materials/materialHelper.functions.ts

packages/dev/core/src/Materials/shaderMaterial.ts

sebavan · 2025-11-19T00:50:47Z

@MiiBond fyi cause I think some of the comments went in late :-)

bjsplat · 2025-11-21T21:37:32Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Popov72 · 2025-11-24T18:33:03Z

I didn't have time today, but I will review the PR tomorrow.

bjsplat · 2025-11-24T18:33:45Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Popov72 · 2025-11-25T17:04:10Z

You should remove package-lock.json from the PR.

packages/dev/core/src/Materials/materialHelper.functions.ts

packages/dev/core/src/Materials/shaderMaterial.ts

packages/dev/core/src/ShadersWGSL/iblVoxelGrid.vertex.fx

sebavan · 2025-12-08T16:42:38Z

cc @MiiBond for the last batch of comments :-)

bjsplat · 2025-12-10T23:34:06Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

packages/dev/core/src/Materials/materialHelper.functions.ts

bjsplat · 2025-12-11T18:25:02Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-12-11T18:52:53Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

MiiBond · 2025-12-11T18:59:55Z

I finally got back to this. I barely remember what I was doing in this code but I think I've fixed most of the issues. I can see the shadows animate now for skinned meshes and morph target meshes.

bjsplat · 2025-12-11T19:00:43Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

packages/dev/core/src/ShadersWGSL/iblVoxelGrid.vertex.fx

bjsplat · 2025-12-11T19:16:42Z

Snapshot stored with reference name:
refs/pull/17376/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/index.html#WGZLGJ#4600

Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves):

https://playground.babylonjs.com/?snapshot=refs/pull/17376/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17376/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17376/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17376/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17376/merge#BCU1XR#0

If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools.

bjsplat · 2025-12-11T19:20:58Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-12-11T19:31:00Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-12-11T19:31:25Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-12-11T19:31:35Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-12-11T22:39:35Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-12-11T22:50:06Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-12-11T22:50:50Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-12-11T22:51:15Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/devhostplaywright/index.html

sebavan · 2025-12-12T19:17:14Z

packages/dev/core/src/Materials/materialHelper.functions.ts

+/**
+ * Interface representing metadata for vertex pulling
+ */
+export interface IVertexPullingMetadata {


Could we move everything related to Vertex Pulling in a vertexPullingHelper.functions.ts ?

sebavan · 2025-12-12T19:17:54Z

packages/dev/core/src/Materials/shaderMaterial.ts

        }

+        const renderingMesh = subMesh ? subMesh.getRenderingMesh() : mesh;
+        if (renderingMesh && this.useVertexPulling) {


Can we use the same condition with the code adding the defines ?

sebavan · 2025-12-15T16:10:27Z

cc @MiiBond for the last round of update and I ll merge it in. Thanks a lot for the fix interleaved buffer fix :-)

Supersedes #17376 --------- Co-authored-by: Mike Bond <mdcbond@gmail.com> Co-authored-by: Popov72 <github@evpopov.com> Co-authored-by: Michael Bond <mbond@adobe.com>

sebavan · 2025-12-30T22:54:32Z

I merged a PR including your changes and the feedback

MiiBond commented Oct 31, 2025

View reviewed changes

packages/dev/core/src/ShadersWGSL/iblVoxelGrid.vertex.fx Outdated Show resolved Hide resolved

deltakosh requested a review from Popov72 November 1, 2025 00:15

MiiBond force-pushed the mbond/voxel-shadow-fixes branch from 1cee238 to ce4c445 Compare November 7, 2025 19:31

Popov72 reviewed Nov 10, 2025

View reviewed changes

packages/dev/core/src/Materials/materialHelper.functions.ts Show resolved Hide resolved

packages/dev/core/src/Materials/shaderMaterial.ts Outdated Show resolved Hide resolved

MiiBond force-pushed the mbond/voxel-shadow-fixes branch from ce4c445 to 33b07ed Compare November 21, 2025 20:57

Popov72 reviewed Nov 25, 2025

View reviewed changes

Mike Bond and others added 2 commits December 10, 2025 14:50

Fix for vertex pulling of interleaved buffers

2a8452a

Fix bones when using vertex pulling

37c0048

MiiBond force-pushed the mbond/voxel-shadow-fixes branch from 437c627 to a23da70 Compare December 10, 2025 23:32

Popov72 reviewed Dec 11, 2025

View reviewed changes

packages/dev/core/src/Materials/materialHelper.functions.ts Outdated Show resolved Hide resolved

Popov72 reviewed Dec 11, 2025

View reviewed changes

packages/dev/core/src/Materials/materialHelper.functions.ts Outdated Show resolved Hide resolved

WebGPU voxelization fixes

bf29406

Fix WebGPU voxelization skinning shader

94bcbe5

Address PR comments

3c8bb21

Popov72 reviewed Dec 11, 2025

View reviewed changes

packages/dev/core/src/ShadersWGSL/iblVoxelGrid.vertex.fx Outdated Show resolved Hide resolved

Address PR comments

9df56ea

Popov72 approved these changes Dec 11, 2025

View reviewed changes

sebavan reviewed Dec 12, 2025

View reviewed changes

sebavan mentioned this pull request Dec 30, 2025

Voxel shadow fixes for interleaved buffers #17598

Merged

sebavan closed this Dec 30, 2025

Conversation

MiiBond commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

MiiBond commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjsplat commented Nov 7, 2025

Uh oh!

bjsplat commented Nov 7, 2025

Uh oh!

bjsplat commented Nov 7, 2025

Uh oh!

bjsplat commented Nov 7, 2025

Uh oh!

Uh oh!

Uh oh!

sebavan commented Nov 19, 2025

Uh oh!

bjsplat commented Nov 21, 2025

Uh oh!

Popov72 commented Nov 24, 2025

Uh oh!

bjsplat commented Nov 24, 2025

Uh oh!

Popov72 commented Nov 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sebavan commented Dec 8, 2025

Uh oh!

bjsplat commented Dec 10, 2025

Uh oh!

Uh oh!

Uh oh!

bjsplat commented Dec 11, 2025

Uh oh!

bjsplat commented Dec 11, 2025

Uh oh!

MiiBond commented Dec 11, 2025

Uh oh!

bjsplat commented Dec 11, 2025

Uh oh!

Uh oh!

bjsplat commented Dec 11, 2025

Uh oh!

bjsplat commented Dec 11, 2025

Uh oh!

bjsplat commented Dec 11, 2025

Uh oh!

bjsplat commented Dec 11, 2025

Uh oh!

bjsplat commented Dec 11, 2025

Uh oh!

bjsplat commented Dec 11, 2025

Uh oh!

MiiBond commented Nov 7, 2025 •

edited

Loading